-
Notifications
You must be signed in to change notification settings - Fork 509
Plugin: Add config-based control for global conference roles visibility in BBB - refs #3498 #6336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
} | ||
} | ||
|
||
return false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid too many return
statements within this method.
break; | ||
case STUDENT_BOSS: | ||
if (api_is_student_boss()) { | ||
return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid too many return
statements within this method.
@@ -159,6 +159,42 @@ public static function updateCourseFieldInAllCourses(string $variable, string $v | |||
$entityManager->flush(); | |||
} | |||
|
|||
public function canCurrentUserSeeGlobalConferenceLink(): bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method canCurrentUserSeeGlobalConferenceLink
has 29 lines of code (exceeds 25 allowed). Consider refactoring.
@@ -159,6 +159,42 @@ public static function updateCourseFieldInAllCourses(string $variable, string $v | |||
$entityManager->flush(); | |||
} | |||
|
|||
public function canCurrentUserSeeGlobalConferenceLink(): bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function canCurrentUserSeeGlobalConferenceLink
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Gradebook: Fix certificate visibility logic for owner and privileged users - refs chamilo#3536
/** | ||
* Installs the plugin | ||
*/ | ||
public function install(): void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function install
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
/** | ||
* Installs the plugin | ||
*/ | ||
public function install(): void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method install
has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Code Climate has analyzed commit 9448fca and detected 9 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Looks good. Merging. |
No description provided.