Skip to content

Plugin: Add config-based control for global conference roles visibility in BBB - refs #3498 #6336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 9, 2025

Conversation

christianbeeznest
Copy link
Contributor

No description provided.

}
}

return false;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid too many return statements within this method.

break;
case STUDENT_BOSS:
if (api_is_student_boss()) {
return true;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid too many return statements within this method.

@@ -159,6 +159,42 @@ public static function updateCourseFieldInAllCourses(string $variable, string $v
$entityManager->flush();
}

public function canCurrentUserSeeGlobalConferenceLink(): bool
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method canCurrentUserSeeGlobalConferenceLink has 29 lines of code (exceeds 25 allowed). Consider refactoring.

@@ -159,6 +159,42 @@ public static function updateCourseFieldInAllCourses(string $variable, string $v
$entityManager->flush();
}

public function canCurrentUserSeeGlobalConferenceLink(): bool
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function canCurrentUserSeeGlobalConferenceLink has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.

/**
* Installs the plugin
*/
public function install(): void
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function install has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.

/**
* Installs the plugin
*/
public function install(): void
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method install has 50 lines of code (exceeds 25 allowed). Consider refactoring.

Copy link

codeclimate bot commented Jul 9, 2025

Code Climate has analyzed commit 9448fca and detected 9 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 7
Duplication 2

View more on Code Climate.

@ywarnier
Copy link
Member

ywarnier commented Jul 9, 2025

Looks good. Merging.

@ywarnier ywarnier merged commit 55adc1c into chamilo:master Jul 9, 2025
2 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants